Skip to content

Support string id field #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2022
Merged

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented May 21, 2022

It partially solves #110 by supporting id field with string value.

Currently cwltest copies label field to short_name field and print it for each test.
This request decides short_name as follows:

  • use label field if available
  • use id field if it has a string value
  • otherwise cwltest does not set short_name as same as before this request

$ ./run_test.sh -l
...
[306] Default inputs, choose step to run based on what was provided, first case
[307] Default inputs, choose step to run based on what was provided, second case
...
  • After merging this request:
$ ./run_test.sh -l
...
[306] cond-with-defaults-1: Default inputs, choose step to run based on what was provided, first case
[307] cond-with-defaults-2: Default inputs, choose step to run based on what was provided, second case
...

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #137 (6b254df) into main (9dac068) will increase coverage by 0.48%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   56.94%   57.43%   +0.48%     
==========================================
  Files           2        2              
  Lines         439      444       +5     
  Branches      128      130       +2     
==========================================
+ Hits          250      255       +5     
  Misses        146      146              
  Partials       43       43              
Impacted Files Coverage Δ
cwltest/__init__.py 60.61% <100.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dac068...6b254df. Read the comment docs.

@tom-tan tom-tan mentioned this pull request May 21, 2022
7 tasks
@mr-c mr-c merged commit 4e842e8 into common-workflow-language:main May 21, 2022
@tom-tan tom-tan deleted the string-id branch May 21, 2022 13:20
@tom-tan
Copy link
Member Author

tom-tan commented May 21, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants