-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(engine.ts): Fix typo in subject prompt #73
base: master
Are you sure you want to change the base?
Conversation
Hopefully you are nice and relaxed when writing your commit messages.
Dupe of #72? 😄 |
Ah, I see what you are trying to say now. The problem is that "short" is an adjective, which applies to "description", but "tense" is a noun, to which "imperative" applies as an adjective, so to make it grammatically correct, it should be "short, imperatively tensed description", with "tense" becoming a past participle (effectively making it an adjective) for "description", and "imperative" becoming an adverb describing "imperatively". Having said that, "Write a short, imperatively tensed description of the change:" might sound funny to some people, so some other ways are:
Or, if only one other person and I have found this a problem and everybody else understands what you are trying to say, then you can leave it be. |
I'd be happy with an update to the text, especially since this keeps coming up ping @commitizen/admins |
Sure thing. Any preferences for phrasing? Personally, I like "Write a short, imperatively tensed description of the change", but I know that might sound arcane to some people. I like the second of the three alternatives, because the parentheses draw the reader's attention, and it is another imperative phrase, which will make people more likely to follow it. |
Oh, and as pointed out in #71, it should be "mood", not "tense", as grammatical tense is only about time. It kept feeling very strange to me every time that I read or wrote it but could not quite put my finger on it. I will change that at the same time in the PR. |
If you change this to mood I'll merge it. |
Hopefully you are nice and relaxed when writing your commit messages.