Skip to content

Feature: version providers #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 12, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(providers): add support for some JSON-based version providers (N…
…PM, Composer)
  • Loading branch information
noirbizarre committed Feb 11, 2023
commit 4a5fda3c5a874aa8865b420419a7d2a426e79282
43 changes: 42 additions & 1 deletion commitizen/providers.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
from __future__ import annotations

import json
from abc import ABC, abstractmethod
from pathlib import Path
from typing import ClassVar, cast
from typing import Any, ClassVar, cast

import importlib_metadata as metadata
import tomlkit
Expand Down Expand Up @@ -122,6 +123,46 @@ def set(self, document: tomlkit.TOMLDocument, version: str):
document["package"]["version"] = version # type: ignore


class JsonProvider(FileProvider):
"""
Base class for JSON-based version providers
"""

indent: ClassVar[int] = 2

def get_version(self) -> str:
document = json.loads(self.file.read_text())
return self.get(document)

def set_version(self, version: str):
document = json.loads(self.file.read_text())
self.set(document, version)
self.file.write_text(json.dumps(document, indent=self.indent) + "\n")

def get(self, document: dict[str, Any]) -> str:
return document["version"] # type: ignore

def set(self, document: dict[str, Any], version: str):
document["version"] = version


class NpmProvider(JsonProvider):
"""
npm package.json version management
"""

filename = "package.json"


class ComposerProvider(JsonProvider):
"""
Composer version management
"""

filename = "composer.json"
indent = 4


def get_provider(config: BaseConfig) -> VersionProvider:
"""
Get the version provider as defined in the configuration
Expand Down
2 changes: 2 additions & 0 deletions docs/config.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ Commitizen provides some version providers for some well known formats:
| `pep621` | Get and set version from `pyproject.toml` `project.version` field |
| `poetry` | Get and set version from `pyproject.toml` `tool.poetry.version` field |
| `cargo` | Get and set version from `Cargo.toml` `project.version` field |
| `npm` | Get and set version from `package.json` `project.version` field |
| `composer` | Get and set version from `composer.json` `project.version` field |

### Custom version provider

Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ cz_customize = "commitizen.cz.customize:CustomizeCommitsCz"
[tool.poetry.plugins."commitizen.provider"]
cargo = "commitizen.providers:CargoProvider"
commitizen = "commitizen.providers:CommitizenProvider"
composer = "commitizen.providers:ComposerProvider"
npm = "commitizen.providers:NpmProvider"
pep621 = "commitizen.providers:Pep621Provider"
poetry = "commitizen.providers:PoetryProvider"

Expand Down
60 changes: 60 additions & 0 deletions tests/test_version_providers.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
from commitizen.providers import (
CargoProvider,
CommitizenProvider,
ComposerProvider,
NpmProvider,
Pep621Provider,
PoetryProvider,
get_provider,
Expand Down Expand Up @@ -125,3 +127,61 @@ def test_cargo_provider(config: BaseConfig, chdir: Path):
version = "43.1"
"""
)


def test_npm_provider(config: BaseConfig, chdir: Path):
package_json = chdir / "package.json"
package_json.write_text(
dedent(
"""\
{
"name": "whatever",
"version": "0.1.0"
}
"""
)
)
config.settings["version_provider"] = "npm"

provider = get_provider(config)
assert isinstance(provider, NpmProvider)
assert provider.get_version() == "0.1.0"

provider.set_version("43.1")
assert package_json.read_text() == dedent(
"""\
{
"name": "whatever",
"version": "43.1"
}
"""
)


def test_composer_provider(config: BaseConfig, chdir: Path):
composer_json = chdir / "composer.json"
composer_json.write_text(
dedent(
"""\
{
"name": "whatever",
"version": "0.1.0"
}
"""
)
)
config.settings["version_provider"] = "composer"

provider = get_provider(config)
assert isinstance(provider, ComposerProvider)
assert provider.get_version() == "0.1.0"

provider.set_version("43.1")
assert composer_json.read_text() == dedent(
"""\
{
"name": "whatever",
"version": "43.1"
}
"""
)