Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test case changes due to tomlkit upgrade #626

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Nov 28, 2022

Description

as title

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

pass the test after installing the latest dependencies

Steps to Test This Pull Request

  1. poetry update
  2. poetry install
  3. ./scripts/test

Additional context

@Lee-W Lee-W requested a review from woile November 28, 2022 15:02
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 98.40% // Head: 97.92% // Decreases project coverage by -0.48% ⚠️

Coverage data is based on head (db42a95) compared to base (2ba0b73).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
- Coverage   98.40%   97.92%   -0.49%     
==========================================
  Files          39       35       -4     
  Lines        1634     1252     -382     
==========================================
- Hits         1608     1226     -382     
  Misses         26       26              
Flag Coverage Δ
unittests 97.92% <100.00%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/cli.py 93.93% <ø> (ø)
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/bump.py 97.31% <100.00%> (+0.27%) ⬆️
commitizen/commands/check.py 100.00% <100.00%> (ø)
commitizen/defaults.py 100.00% <100.00%> (ø)
commitizen/bump.py
commitizen/changelog.py
commitizen/exceptions.py
commitizen/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lee-W Lee-W force-pushed the fix-test-case-change-due-to-tomlkit-upgrade branch from 2d01ff9 to 0aa9362 Compare November 28, 2022 16:44
@Lee-W Lee-W force-pushed the fix-test-case-change-due-to-tomlkit-upgrade branch from f3f28ef to db42a95 Compare November 29, 2022 02:52
@woile woile merged commit dc10df0 into master Nov 29, 2022
@woile woile deleted the fix-test-case-change-due-to-tomlkit-upgrade branch November 29, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants