Skip to content

fix(bump): Search for version number line by line #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ci(pre-commit): Remove version_files lookahead
Commitizen runs bump on itself to, among other things, manage the
version it uses of its own pre-commit hooks. When searching
.pre-commit-config.yaml for the version number of Commitizen, we search
for "Commitizen," which is in a comment to the right of the version
number. Remove the lookahead assertion for "Commitizen," and instead
simply consume it when matching now that version_files regexes don't
need to exclusively match to the left of the version number.
  • Loading branch information
Kurt-von-Laven committed Aug 22, 2022
commit 7f7a6068754e0d05aee39d97b43f41de48dd9b41
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ tag_format = "v$version"
version_files = [
"pyproject.toml:version",
"commitizen/__version__.py",
".pre-commit-config.yaml:rev:.\\s+(?=[^\\n]+Commitizen)"
".pre-commit-config.yaml:rev:.+Commitizen"
]

[tool.black]
Expand Down