Skip to content

git.get_commits error check #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 21, 2022
Merged

git.get_commits error check #540

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d36c0c2
fix(git): improves git error checking in get_commits
bhelgs Aug 1, 2022
9b243a3
test(bump): fixes logic issue made evident by the latest fix(git) commit
bhelgs Aug 1, 2022
5318325
test(changelog): fixes logic issue made evident by latest fix(git) co…
bhelgs Aug 1, 2022
b4dbd84
refactor(changelog): fixes logic issue made evident by latest fix(git…
bhelgs Aug 1, 2022
91ed065
test(check): fixes logic issue made evident by the latest fix(git) co…
bhelgs Aug 1, 2022
991e829
fix(git): Improves error checking in get_tags
bhelgs Aug 1, 2022
d5b67b0
test(changelog): code coverage improvements
bhelgs Aug 2, 2022
7562808
refactor(git): test the git log parser behaves properly when the repo…
bhelgs Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(check): fixes logic issue made evident by the latest fix(git) co… 
…mmit

git was failing with "fatal: ambiguous argument 'master..master': unknown revision or path not in the working tree". git `master` branch doesn't exist unless there is at least one "initial" commit or when only the PR branch has been cloned (e.g. CI).
  • Loading branch information
@bhelgs
bhelgs committed Aug 14, 2022
commit 91ed06516f9494f3b12b343503336ef96bfb6bd6
6 changes: 6 additions & 0 deletions tests/commands/test_check_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
InvalidCommitMessageError,
NoCommitsFoundError,
)
from tests.utils import create_file_and_commit

COMMIT_LOG = [
"refactor: A code change that neither fixes a bug nor adds a feature",
Expand Down Expand Up @@ -217,7 +218,12 @@ def test_check_command_with_invalid_argument(config):
)


@pytest.mark.usefixtures("tmp_commitizen_project")
def test_check_command_with_empty_range(config, mocker):

# must initialize git with a commit
create_file_and_commit("feat: initial")

check_cmd = commands.Check(config=config, arguments={"rev_range": "master..master"})
with pytest.raises(NoCommitsFoundError) as excinfo:
check_cmd()
Expand Down