fix(git): commit bodies with carriage returns are correctly split by …#1780
Merged
bearomorphism merged 4 commits intocommitizen-tools:masterfrom Jan 15, 2026
Merged
Conversation
…line This should enable us to correctly parse squashed commits made on an SCM server residing on a Windows OS.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1780 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 60 60
Lines 2606 2606
=======================================
Hits 2551 2551
Misses 55 55 ☔ View full report in Codecov by Sentry. |
Collaborator
bearomorphism
left a comment
There was a problem hiding this comment.
Overall good, but I noticed a small inconsistency between the test and the implementation
bearomorphism
approved these changes
Jan 9, 2026
Collaborator
bearomorphism
left a comment
There was a problem hiding this comment.
LGTM, thanks!
@woile @Lee-W @noirbizarre could you also take a look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... line
This should enable us to correctly parse squashed commits made on an SCM server residing on a Windows OS.
Description
Checklist
Code Changes
uv run poe alllocally to ensure this change passes linter check and testsDocumentation Changes
uv run poe doclocally to ensure the documentation pages renders correctlyExpected Behavior
Commit bodies that use carriage returns for line breaks will now be successfully split when getting processed. In particular this enables commitizen to process squash commits made on an SCM server that is hosted by a Windows OS.
Steps to Test This Pull Request
\r\n):cz changelog --dry-runand verify that only thefeatandfixentries are included\n)cz changelog --dry-runand verify that only thefeatandfixentries are includedAdditional Context