refactor(init): code cleanup and better test coverage #1424
+440
−207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
force-pushed
the
refactor-init
branch
from
b3d3048 to
a36b7ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
+ Coverage 97.33% 98.12% +0.78%
==========================================
Files 42 57 +15
Lines 2104 2661 +557
==========================================
+ Hits 2048 2611 +563
+ Misses 56 50 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
commented
May 17, 2025
|
|
||
| commands.Init(config)() | ||
| check_cz_config(default_choice) | ||
| # check that config is not duplicated | ||
| check_pre_commit_config([cz_hook_config]) | ||
| check_pre_commit_config([CZ_HOOK_CONFIG]) | ||
|
|
||
|
|
||
| class TestNoPreCommitInstalled: |
There was a problem hiding this comment.
test_pre_commit_not_installed is not working as expected...
bearomorphism
commented
May 17, 2025
| "update_changelog_on_bump = true\n" | ||
| "major_version_zero = true\n" | ||
| 'version = "0.0.1"\n' |
There was a problem hiding this comment.
Does the order of these configs matter here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context