Skip to content

refactor(customize): improve code readability #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −37
Open

refactor(customize): improve code readability #1412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 17 additions & 37 deletions commitizen/cz/customize/customize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,46 +21,32 @@


class CustomizeCommitsCz(BaseCommitizen):
bump_pattern = defaults.bump_pattern
bump_map = defaults.bump_map
bump_map_major_version_zero = defaults.bump_map_major_version_zero
change_type_order = defaults.change_type_order

def __init__(self, config: BaseConfig):
super().__init__(config)

if "customize" not in self.config.settings:
raise MissingCzCustomizeConfigError()
self.custom_settings = self.config.settings["customize"]

custom_bump_pattern = self.custom_settings.get("bump_pattern")
if custom_bump_pattern:
self.bump_pattern = custom_bump_pattern

custom_bump_map = self.custom_settings.get("bump_map")
if custom_bump_map:
self.bump_map = custom_bump_map

custom_bump_map_major_version_zero = self.custom_settings.get(
"bump_map_major_version_zero"
self.bump_pattern = (
self.custom_settings.get("bump_pattern") or defaults.bump_pattern
)
self.bump_map = self.custom_settings.get("bump_map") or defaults.bump_map
self.bump_map_major_version_zero = (
self.custom_settings.get("bump_map_major_version_zero")
or defaults.bump_map_major_version_zero
)
self.change_type_order = (
self.custom_settings.get("change_type_order") or defaults.change_type_order
)
if custom_bump_map_major_version_zero:
self.bump_map_major_version_zero = custom_bump_map_major_version_zero

custom_change_type_order = self.custom_settings.get("change_type_order")
if custom_change_type_order:
self.change_type_order = custom_change_type_order

commit_parser = self.custom_settings.get("commit_parser")
if commit_parser:
if commit_parser := self.custom_settings.get("commit_parser"):
self.commit_parser = commit_parser

changelog_pattern = self.custom_settings.get("changelog_pattern")
if changelog_pattern:
if changelog_pattern := self.custom_settings.get("changelog_pattern"):
self.changelog_pattern = changelog_pattern

change_type_map = self.custom_settings.get("change_type_map")
if change_type_map:
if change_type_map := self.custom_settings.get("change_type_map"):
self.change_type_map = change_type_map

def questions(self) -> Questions:
Expand All @@ -70,8 +56,7 @@ def message(self, answers: dict) -> str:
message_template = Template(self.custom_settings.get("message_template", ""))
if getattr(Template, "substitute", None):
return message_template.substitute(**answers) # type: ignore
else:
return message_template.render(**answers)
return message_template.render(**answers)

def example(self) -> str:
return self.custom_settings.get("example") or ""
Expand All @@ -83,12 +68,7 @@ def schema(self) -> str:
return self.custom_settings.get("schema") or ""

def info(self) -> str:
info_path = self.custom_settings.get("info_path")
info = self.custom_settings.get("info")
if info_path:
if info_path := self.custom_settings.get("info_path"):
with open(info_path, encoding=self.config.settings["encoding"]) as f:
content = f.read()
return content
elif info:
return info
return ""
return f.read()
return self.custom_settings.get("info") or ""