Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set shell to False if running subprocess on Windows #1124

Closed
wants to merge 1 commit into from

Conversation

my1e5
Copy link

@my1e5 my1e5 commented May 20, 2024

Description

When running a subprocess through run in cmd.py, if the OS is Windows set shell=False.

Closes #1118 and #1117

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Running rye run cz bump on a Windows machine in a rye-managed project now works.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.58%. Comparing base (120d514) to head (d0fdb2f).
Report is 439 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
+ Coverage   97.33%   97.58%   +0.24%     
==========================================
  Files          42       55      +13     
  Lines        2104     2486     +382     
==========================================
+ Hits         2048     2426     +378     
- Misses         56       60       +4     
Flag Coverage Δ
unittests 97.58% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W
Copy link
Member

Lee-W commented May 20, 2024

Looks like CI is failing on windows. We might need to take a deeper look

AdrianDC added a commit to AdrianDC/commitizen that referenced this pull request Aug 22, 2024
@my1e5 my1e5 closed this by deleting the head repository Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cz bump fails when running with rye
2 participants