fix: set shell to False if running subprocess on Windows #1124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running a subprocess through
run
incmd.py
, if the OS is Windows setshell=False
.Closes #1118 and #1117
Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and testExpected behavior
Running
rye run cz bump
on a Windows machine in a rye-managed project now works.