Skip to content

Add graphql support to node backend - #17

Merged
larrylin17 merged 34 commits into
mainfrom
add-graphql-support-to-node-backend
Mar 8, 2021
Merged

Add graphql support to node backend#17
larrylin17 merged 34 commits into
mainfrom
add-graphql-support-to-node-backend

Conversation

@larrylin17

Copy link
Copy Markdown
Contributor

pass local testing
pass CirculeCI build

take apollo apis as the datasources
@larrylin17
larrylin17 force-pushed the add-graphql-support-to-node-backend branch from 584341a to c7edb33 Compare February 19, 2021 19:25
@bmonkman

Copy link
Copy Markdown
Contributor

How will this be templated so that you can choose either GraphQL or REST?

Comment thread templates/src/app/graphql/utils.js Outdated
@bmonkman

Copy link
Copy Markdown
Contributor

store.sqlite should not be checked in

@bmonkman

bmonkman commented Feb 19, 2021

Copy link
Copy Markdown
Contributor

Can you strip down the functionality a bit? It doesn't need to be a full implementation of a feature (like you've done with "launch") but just an example of how to implement a query and mutation in GraphQL. It's less important to have a full usable feature and more important to show a good example that is going to be easy for a user to adapt when they create their own API.
Ideally the project would be structured in such a way that all the code that is just examples is grouped together so that it's easy for a user to remove it when they are ready to start their own.

@bmonkman

Copy link
Copy Markdown
Contributor

Can you add some documentation?

  • Links / resources for GraphQL
  • How is the project structured?
  • How does a user define their own schema?
  • Which pieces of the code are just examples that a user can delete and which are critical functionality?
  • etc.

@larrylin17

Copy link
Copy Markdown
Contributor Author

Can you add some documentation?

  • Links / resources for GraphQL
  • How is the project structured?
  • How does a user define their own schema?
  • Which pieces of the code are just examples that a user can delete and which are critical functionality?
  • etc.

Yes, I can add them.

@larrylin17

Copy link
Copy Markdown
Contributor Author

store.sqlite should not be checked in

Has removed. Thanks.

@larrylin17

Copy link
Copy Markdown
Contributor Author

How will this be templated so that you can choose either GraphQL or REST?

added the following 2 snippets in zero-module.yml. Does it look good?

  - field: graphql
    label: Enable graphql and apollo server?
    default: yes
    options:
      - "yes"
      - "no"
  - action: ignoreFile
    matchField: graphql
    whenValue: "no"
    data:
    - src/app/graphql

Comment thread templates/src/app.js
Comment thread zero-module.yml Outdated
Comment thread templates/kubernetes/overlays/production/kustomization.yml Outdated
@larrylin17
larrylin17 requested a review from bmonkman March 2, 2021 22:00
Comment thread templates/src/middleware/auth/jwtDecoder.js Outdated
Comment thread templates/src/service/file.js Outdated
Comment thread templates/src/graphql/schema.js Outdated
Comment thread templates/src/graphql/schema.js Outdated
Comment thread templates/src/graphql/resolvers.js
Comment thread templates/src/app.js Outdated
Comment thread templates/src/graphql/default.graphql Outdated
Comment thread templates/src/middleware/auth/index.js Outdated
@bmonkman

bmonkman commented Mar 6, 2021

Copy link
Copy Markdown
Contributor

Just those last two things, I think!

@larrylin17
larrylin17 merged commit a4e1032 into main Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants