Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes for video attachments #305

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Small fixes for video attachments #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion commet/lib/ui/molecules/video_player/video_player_implementation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,6 @@ class _VideoPlayerImplementationState extends State<VideoPlayerImplementation> {
}

return Size(
player.state.height!.toDouble(), player.state.width!.toDouble());
player.state.width!.toDouble(), player.state.height!.toDouble());
}
}
6 changes: 6 additions & 0 deletions commet/lib/ui/organisms/attachment_processor/attachment_processor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ class _AttachmentProcessorState extends State<AttachmentProcessor> {
super.initState();
}

@override
void dispose() {
videoController?.pause();
super.dispose();
}

void loadExif() async {
late Map<String, IfdTag> data;
if (widget.attachment.data != null) {
Expand Down
6 changes: 5 additions & 1 deletion tiamat/lib/atoms/panel.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@ class Panel extends StatelessWidget {
padding: const EdgeInsets.fromLTRB(8, 8, 0, 0),
child: Align(
alignment: Alignment.centerLeft,
child: tiamat.Text.labelLow(header!)),
child: tiamat.Text.labelLow(
header!,
maxLines: 1,
overflow: TextOverflow.ellipsis,
)),
),
if (header != null)
Padding(
Expand Down
Loading