Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 1:1 Calls #209

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Implement 1:1 Calls #209

wants to merge 34 commits into from

Conversation

Airyzz
Copy link
Contributor

@Airyzz Airyzz commented Apr 12, 2024

No description provided.

@Airyzz
Copy link
Contributor Author

Airyzz commented Apr 14, 2024

looks like flutter_webrtc package is causing integration test to fail, even if it isnt being used in the actual app. Going to have to disable integration test for now, and investigate this issue later

@notramo
Copy link

notramo commented May 29, 2024

@Airyzz, this is really cool, is there any ETA for this?

@Airyzz
Copy link
Contributor Author

Airyzz commented May 29, 2024

@Airyzz, this is really cool, is there any ETA for this?

Thanks! No ETA at the moment as I need to evaluate what changes I need to make for MatrixRTC support

@theotheroracle
Copy link

this is immensely epic

@notramo
Copy link

notramo commented May 29, 2024

@Airyzz as MatrixRTC is still in the making, I would recommend adding calls using the current spec (probably behind a labs switch, or a notification when first used), for multiple reasons:

  • Gain some popularity for this client (calls are one of the most requested features, for most client, directly 2nd place behind threading)
  • See possible pitfalls in the implementation (mostly network or event ordering/sending corner cases, that should be considered when designing). The Element and Matrix.org team often puts out barely working demos solely for the purpose of experimenting.
  • Some clients will probably lack behind MatrixRTC support and use current VoIP spec for a few months.

(Sorry if my comment is dumb, I haven't yet catched up with the MatrixRTC spec, and don't exactly know what is included in it and what is not, neither the differences from the current VoIP spec.)

@Airyzz
Copy link
Contributor Author

Airyzz commented May 29, 2024

@notramo I think its a good point - it does still need evaluating though because I believe the matrix SDK has had some changes since I last worked on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants