Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6643 Respect --no-run-tests, --no-run-benchmarks when listing actions #6645

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

mpilgrem
Copy link
Member

See:

Puts notification (if enabled) in Stack.Build.Execute.executePlan'.

In Stack.Build.Execute.toActions:

  • does not add action singleTest if not runTests; and
  • does not add action singleBench if not runBenchmarks.

Please include the following checklist in your pull request:

  • Any changes that could be relevant to users have been recorded in ChangeLog.md.
  • The documentation has been updated, if necessary

Please also shortly describe how you tested your change. Bonus points for added tests!

@mpilgrem
Copy link
Member Author

@theobat, as you have been looking at the architecture of Stack, I would be very grateful if you could spare any time to look at this pull request, as I consider its change to be architectural (even if it is relatively minor).

@theobat
Copy link
Contributor

theobat commented Aug 29, 2024

@mpilgrem It looks good to me, though I'd place a user visible warning in case the unreachable code is reached, with an invitation to open an issue.
Also I'm wondering if stack should not prevent tests from being built in case they are disabled, I don't know, the good build behavior is not obvious to me...

@mpilgrem mpilgrem merged commit 4cb95b4 into master Sep 7, 2024
14 checks passed
@mpilgrem mpilgrem deleted the fix6643 branch September 7, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants