Also resolve auto-generated component files. #5393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"... didn't break any of the tests when I ran them on my machine" I should have said. :) I'll look into the test failures. |
|
Oh, never mind. The failing tests seem to be build issues caused by |
|
FWIW, in our project we've been getting failures to download from the fpcomplete server, so nice to know it's not just us! |
|
Also: the server issues should hopefully be fixed. It's a temporary patch right now, but a better fix is coming. Also, we're hoping to get a new Stack release out the door. We already have the commits on |
|
Great! Thanks for the review and for the merge. Current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to address #5392.
It basically passes the Cabal version down to the place where it's needed to generate the directory paths that hold auto-generated files,
resolveComponentFiles. These directories are then used in addition to thehs-source-dirsdirectories to find.hsfiles for a component's modules.I'm only superficially familiar with the
stackcodebase, but it seems that at least this doesn't break any of the tests.