-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for non-ASCII module names #4939
Conversation
The new integration test seems to be failing on macOS on CI (see https://dev.azure.com/commercialhaskell/stack/_build/results?buildId=1945) However, I just tried locally on my MacBook Pro and it seems to pass here, so not sure what's going on. |
It might depend on the file system. https://apple.stackexchange.com/questions/83935/unicode-normalization-for-filenames-and-copied-text-from-pdfs
|
An easy way to find out if that is the case would be to try with |
This fixes an integration test failure (see #4939 (comment))
I did a trial of upgrading CI to Mojave/10.14 (it was on High Sierra/10.13), and that may have fixed it. Doing the full test now with Mojave. Aside from that, indications so far are that this is not triggered in Stack itself but more likely in GHC's package handling (or maybe Cabal). |
#4953, which upgrades CI to Mojave, looks to fix this on Azure (see https://dev.azure.com/commercialhaskell/stack/_build/results?buildId=1955). @snoyberg did discover that the |
I didn't quite catch if the change you made fixes the problem on both HFS+ and APFS… it sounded like it is likely still broken on HFS+?? (I assume the High Sierra builds were on HFS+ and Mojave on APFS.) FWIW elsewhere I have used unicode-transforms to normalize filenames in macOS to be able to work with them in a sane fashion (e.g.,
(There is a If |
I think this needs some more investigation. I actually thought my system was still on HFS+, but turns out upgrading to Mojave also changed my filesystem to APFS, so probably the same is true on Azure CI. So what you say about it still being broken with HFS+ is very plausible. The original bug that was fixed was a problem on all operating systems and all filesystems, whereas what we're talking about is a different bug that only affects some macOS systems. It's probably better to open a separate issue. |
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Tested manually and added an integration test.
Fixes #4938
Another case when importing
Data.ByteString.Char8
is an error...