Disable nix on windows (#3600) #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgsloan
force-pushed
the
disable-nix-on-windows-3600
branch
2 times, most recently
from
e0fab20
to
5f3e232
Compare
mgsloan
force-pushed
the
disable-nix-on-windows-3600
branch
from
5f3e232
to
3e3c6bd
Compare
snoyberg
approved these changes
Feb 1, 2018
| @@ -32,6 +34,12 @@ nixOptsFromMonoid NixOptsMonoid{..} os = do | |||
| nixShellOptions = fromFirst [] nixMonoidShellOptions | |||
| ++ prefixAll (T.pack "-I") (fromFirst [] nixMonoidPath) | |||
| nixAddGCRoots = fromFirst False nixMonoidAddGCRoots | |||
| nixEnable <- | |||
| if nixEnable0 && osIsWindows | |||
There was a problem hiding this comment.
I can't say exactly what strikes me about this, but I find this code particularly elegant.
mgsloan
force-pushed
the
disable-nix-on-windows-3600
branch
from
3e3c6bd
to
57d5f85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is untested because I do not have convenient access to a windows box. However, the change is trivial, it should work fine.