Stop truncating all-cabal-hashes repo (#2175) #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think it'll be sufficient. Gotta do |
|
Thanks, didn't know that existed! Turns out I have to do --unshallow iff |
Blaisorblade
changed the title
|
Testing transition locally by hand in parallel with CI, so don't merge yet (hence [HOLD]). |
Fix #2175. * Fetch full history of tags (in particular, `current-hackage`). * Before fetching tags, transition previously shallow repos to be non-shallow with `fetch --unshallow`. * Fetch full history in initial clone, otherwise, we immediately afterwards use `fetch --unshallow`. This means that the initial fetch and later updates require more data, proportional to the entire repository history; however, reducing data usage again is not trivial and would require changes in the layout of all-cabal-hashes, as discussed in #2175.
Blaisorblade
force-pushed
the
2175-dont-truncate-repo
branch
from
188e9f2
to
753a7db
Compare
Blaisorblade
changed the title
|
Local and CI testing completed, and no opposition heard, hence merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2175.
This fix is quite minimal, and it comes with a significant slowdown for the first
stack update, which is why I used "type: discuss" for this PR.However, local tests confirm that #2175 disappers. Note that to see the results, one needs to remove various caches and the repo:
I'd hope
stack updatewould be enough withoutrm -rf ~/.stack/indices/Hackage/git-update, but I'm not sure.EDIT: The AppVeyor failures are due to #2457; but for now I'd wait for a fix and a clean AppVeyor build just to be sure.