-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OpenBSD's tar where possible, require GNU tar for xz support (#2283) #2456
Conversation
Since OpenBSD's tar does not support xz, use only `gtar` there. Stick to `tar` elsewhere. The UX is not perfect but it's already useful.
This supports non-GNU tar programs that do not decompress archives automatically, such as the OpenBSD one.
I tested the '-j' option on OpenBSD and it worked: Before (using Version 1.1.2 x86_64 hpack-0.14.0):
After (using 0ae5411):
Not sure about the error about not being able to find the executable...I was able to |
I looked at the tarball from https://openbsd.dead-parrot.de/distfiles/ghc-7.8.3.20150623-amd64-unknown-openbsd.tar.bz2; I guess the directory is named Looking at #416, you should be able to do a |
Reported broken at commercialhaskell/stack#2456 (comment), and not usable at commercialhaskell/stack#416 (comment). Removal was suggested in commercialhaskell/stack#416 (comment).
LGTM:
|
This PR improves the support for OpenBSD's tar as discussed in #2283. For
.tar.xz
archives that are unsupported there, it will error out and require installinggtar
. For other archives it will specifyz
andj
options (on all platforms), hence supporting OpenBSD tar directly (and I assume staying compatible with other ones).The first commit is already tested by @bonds on OpenBSD, I tested both on OS X, and checked manpages for GNU tar and FreeBSD tar, so this should work there too.
Relevant UNIX man pages:
OpenBSD tar
FreeBSD tar.