Only call logWarn if there's anything to report #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $logWarn $ mconcat $ map (\(path, entryType) -> "Unexpected entry type " <> entryType <> " for entry " <> T.pack path) unexpectedEntries | ||
|
|
||
| F.forM_ unexpectedEntries $ \(path, entryType) -> | ||
| logWarnN $ "Unexpected entry type " <> entryType <> " for entry " <> T.pack path |
There was a problem hiding this comment.
FYI, stack never uses logWarnN, since it doesn't record source file and position. Otherwise LGTM.
There was a problem hiding this comment.
Oh. I didn't know if template haskell would work there. Fixed.
|
LGTM, I'll merge as soon as tests pass again.
Good question. I used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #2418, spurious newlines are being emitted. Doing a
git bisectreduced it to a commit which introduced a$logWarnmessage which seemed responsible. This patch simply wraps the debug statements so that no call is made it the error report is the empty list.(I leave aside the matter of whether this was a good way to do error reporting; I'm just trying to fix the output bug)
AfC