Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis doesn't *really* test cabal builds. #2439

Closed
3 tasks done
Blaisorblade opened this issue Aug 4, 2016 · 0 comments · Fixed by #2440
Closed
3 tasks done

Travis doesn't *really* test cabal builds. #2439

Blaisorblade opened this issue Aug 4, 2016 · 0 comments · Fixed by #2440

Comments

@Blaisorblade
Copy link
Collaborator

Blaisorblade commented Aug 4, 2016

Or rather, it tests them but ignores the errors. See the failures here:
https://travis-ci.org/commercialhaskell/stack/jobs/149459127
https://travis-ci.org/commercialhaskell/stack/jobs/149736106#L435

Those ones are just harmless warnings turned into errors by -Werror.

That's because the travis script composes commands with ; instead of && in the script section. One could fix that also with set -e.

However, the stack build also gives similar warnings, but without -Werror:
https://travis-ci.org/commercialhaskell/stack/jobs/149459130

That's because of cabal configure --enable-tests --enable-benchmarks -v2 --ghc-options="-O0 -Werror" in .travis.yml picks -Werror for cabal, but not for Travis.
My plan:

  • add -Werror to stack builds
  • fix the build script to propagate failures
  • create an issue about those warnings and/or investigating them myself. In particular, the fix might not need conditional compilation: the warning did not exist before 8.0, so hopefully the constraints are also redundant on previous versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants