Don't compare generated cabal files #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For an example of this bug, see commercialhaskell/stack#5045. Problem: pantry was including the hash of generated cabal files in lock files, and then when newly generated cabal files (based on new hpack versions) mismatched, it considered it a different package. Solution: do not store the hash of the generated cabal file, but instead of the source hpack file.
Turns out that these are no longer necessary at all. We cache the relevant information within the Pantry database, and just need name and version for quick checking. This bypasses the entire issue of mismatched cabal file information and keeps nicer backwards compat with existing lock files (just generates a warning for the `cabal-file` field).
snoyberg
added a commit
to commercialhaskell/stack
that referenced
this pull request
Oct 3, 2019
Fixes #5045. See relevant PR for pantry for more details: commercialhaskell/pantry#7
snoyberg
added a commit
to commercialhaskell/stack
that referenced
this pull request
Oct 3, 2019
Fixes #5045. See relevant PR for pantry for more details: commercialhaskell/pantry#7
psibi
reviewed
Oct 3, 2019
psibi
approved these changes
Oct 3, 2019
snoyberg
added a commit
to commercialhaskell/stack
that referenced
this pull request
Oct 3, 2019
Fixes #5045. See relevant PR for pantry for more details: commercialhaskell/pantry#7
snoyberg
added a commit
to commercialhaskell/stack
that referenced
this pull request
Oct 3, 2019
Fixes #5045. See relevant PR for pantry for more details: commercialhaskell/pantry#7
snoyberg
added a commit
to commercialhaskell/stack
that referenced
this pull request
Oct 3, 2019
Fixes #5045. See relevant PR for pantry for more details: commercialhaskell/pantry#7
qrilka
reviewed
Oct 3, 2019
|
That's a good point! It's a better idea to simply ignore the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of the bugs involved here, commercialhaskell/stack#5045.