Skip to content

Re-enable dhall #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

ysangkok
Copy link
Contributor

Checklist for adding a package:

  • Meaningful commit message, eg add my-cool-package (please don't mention the yaml file)

  • Package is already added to nightly (if possible)

  • On your machine, in a new directory, you have successfully run the following set of commands (replacing $package and $version with the name and version of the package you want to add to Stackage LTS):

    stack unpack $package-$version
    cd $package-$version
    stack init --resolver lts
    stack --resolver lts build --haddock --test --bench --no-run-benchmarks
    

or using the verify-package script:

  verify-package $package lts

Now that

is released to hackage as dhall-1.42.2, we can add dhall back to the LTS.
Sadly the other packages are not compatible yet, as far as I can see.

Copy link
Contributor

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mihaimaruseac mihaimaruseac merged commit 1c304ae into commercialhaskell:master Feb 13, 2025
@ysangkok ysangkok deleted the lts-23-dhall branch February 13, 2025 02:50
@mmhat
Copy link

mmhat commented Feb 13, 2025

Nice! Thank you @ysangkok @mihaimaruseac

@mihaimaruseac
Copy link
Contributor

special-values (Grandfathered dependencies, Library and exe bounds failures) (not present) depended on by:

Will disable tests on LTS until we can add special-values

@ysangkok
Copy link
Contributor Author

Pinged the maintainer on

In a week I will ask the trustees to bump.

@ysangkok
Copy link
Contributor Author

@mihaimaruseac I just noticed that while special-values isn't getting bumped on the repo, it has had a compatible revision since December. So I believe it could get added.

@mihaimaruseac
Copy link
Contributor

Oh, that's awesome!

mihaimaruseac added a commit that referenced this pull request May 25, 2025
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants