Skip to content

Conversation

@konn
Copy link
Contributor

@konn konn commented Jan 7, 2025

This PR revives ghc-typelits-presburger in LTS 23, which once got excluded due to getKey incompatibility in GHC 9.8.4. All the packages are tested to be built with GHC 9.8.4 with recent LTS 23 dependencies.

Checklist for adding a package:

  • Meaningful commit message, eg add my-cool-package (please don't mention the yaml file)

  • Package is already added to nightly (if possible)

  • On your machine, in a new directory, you have successfully run the following set of commands (replacing $package and $version with the name and version of the package you want to add to Stackage LTS):

    stack unpack $package-$version
    cd $package-$version
    stack init --resolver lts
    stack --resolver lts build --haddock --test --bench --no-run-benchmarks
    

or using the verify-package script:

  verify-package $package lts

@konn
Copy link
Contributor Author

konn commented Jan 14, 2025

@mihaimaruseac it seems that new minor version of LTS 23 has just been released but without this PR. Is there anything I havd to do to get this PR merged?

@mihaimaruseac
Copy link
Contributor

I think the curator on duty missed it. Next one should review it

@konn
Copy link
Contributor Author

konn commented Jan 20, 2025

Hi, seems LTS 23.5 just have been released. Who should I talk to to get this PR included in the next LTS 23?

@konn
Copy link
Contributor Author

konn commented Jan 23, 2025

@mihaimaruseac Sorry for disturbance, but how can I get in touch with the curator of the next release?

@juhp juhp merged commit 1ec698d into commercialhaskell:master Jan 23, 2025
@juhp
Copy link
Member

juhp commented Jan 23, 2025

Merged, thank you

@konn
Copy link
Contributor Author

konn commented Jan 23, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants