Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set new state for partner products if state is missing #125

Open
michael-s-grant opened this issue Jul 6, 2018 · 3 comments
Open

Set new state for partner products if state is missing #125

michael-s-grant opened this issue Jul 6, 2018 · 3 comments
Assignees
@michael-s-grant
Labels
Impex Minor Status: Review

Comments

@michael-s-grant
Copy link

Internal JIRA ticket number

PIN-1887.*

Description

As a product data manager,
I would like the state for imported products to be set to New if the Marketplace partner has not set it in the CSV connector
So that these products enter the workflow in a legal state.

Expected Behaviour

When new products are imported, the state is set to New if it is not specified.
When products are updated, lack of a state in the product to import should not impede the import; the current state should be maintained.

Context

This work emerged out of the addition of states* to the REWE Marketplace product model.

∗ Sorry, open-source contributors, this link will not be accessible from outside of commercetools and REWE Digital.
@michael-s-grant michael-s-grant self-assigned this Jul 6, 2018
michael-s-grant pushed a commit that referenced this issue Jul 9, 2018
feat(productImport): Set state to New for partner products if state i…
a42e4fb 
…s not specified

Set state to New for REWE Digital Marketplace partner products if state is not specified.
Also, refactor timeout in integration.spec.coffee into a common constant, and increase its value.

Closes: #125
@michael-s-grant michael-s-grant mentioned this issue Jul 9, 2018
Closed
4 tasks
@skyriakou
Copy link

@michael-s-grant is this issue still relevant? If not, can it be closed? Thanks.

@michael-s-grant
Copy link
Author

@skyriakou See the latest comments at #126: I had abandoned work here (as opposed to in sphere-node-product-csv-sync, where I brought it to completion), but your team wanted to finish the work, which is to say just addressing any remaining issues with my pull request, and merge it; so you should really address your question to them.

@skyriakou
Copy link

@michael-s-grant Thank you for the information, We moved it into our backlog.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-s-grant michael-s-grant

Labels
Impex Minor Status: Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(product-import): Set product state when not specified commercetools/sphere-product-import
3 participants
@michael-s-grant @Oehmi @skyriakou