Closed
Conversation
🦋 Changeset detectedLatest commit: 88d39f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
valoriecarli
commented
Jan 29, 2026
Comment on lines
+193
to
+194
| packages/nimbus/src/components/**/intl/ | ||
| packages/nimbus/src/components/**/*.messages.ts |
Update spec documentation to clearly state that NimbusI18nProvider is for date/number formatting (React Aria I18n), not UI text translation. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Fix syntax error in variable message example. The message key must be
properly quoted and variables passed as second parameter.
Before: msg.format("pageInfo, { current: 1, total: 10 }");
After: msg.format("pageInfo", { current: 1, total: 10 });
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
valoriecarli
force-pushed
the
CRAFT-2055-react-intl-ya-really-gone!
branch
from
82381f8 to
88d39f6
Compare
valoriecarli
requested review from
a team,
ByronDWall,
ddouglasz,
jaikamat,
misama-ct,
stephsprinkle and
tylermorrisford
and removed request for
a team
Collaborator
Author
|
@claude Please do an initial review |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-intl→@internationalized/stringmigration started in CRAFT-2029- Migrate from react-intl to compile-time message parsing #841.react-intldep is removed, alldefineMessagesimports are eliminated &@formatjs/cliis replaced with a custom extraction script.gitignoredto follow best practices for generated code.TL;DR:
react-intlis completely gone, extraction is now custom & cleaner, generated files aregitignored& all docs have been updated.Major Change:
Created custom extraction script (
packages/i18n/scripts/extract-messages) to remove thereact-intldevDep..i18nfiles are now plain TS objects with no external dependencies. They exist solely for extraction purposes & are never imported by components at runtime.We now:
Before:
After:
Other goodies in the PR include (but not limited to):