refactor: to remove query to load menu feature toggles #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 06a67ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tdeekens
force-pushed
the
td/remove-menu-feature-toggle-query
branch
from
576ba22
to
06a67ac
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes the query to load all menu feature toggles.
Description
Internal applications can be hidden on demand. This can be due to them not being available across all clouds mostly. As applications pass flags of their interest to LD, so that we don't load all flags, we need to pass flags of other applications (not viewed) to LD too so that they're included in the response.
For this, each application (mostly internals) can declare a
featureToggleproperty on theirmenu.json. This query (in a service) then walks over all internal applications and aggregates those feature toggles by name. These are then passed on to LaunchDarkly, so that LD includes them when building up its flag subscription.When adopting feature flagging we first only relied on LD but soon after build more long-lived feature configuration flags into an internal API exposed using the
allFeaturesquery. We then recommended to use this to enable/disable applications instead of using LD.Currently, all teams use the allFeatures query to enable/disable applications across environments or projects (during rollout). No team uses, or intends to, use LD for this. In addition with using lazy caching with LD it becomes less interesting to use LD as flag rule changes don't affect running applications instantly any more.
As a result we can remove this query entirely. Saving us a query at boot time of the application. It also lowers the options to hide applications. Internally we will also adopt an
enableApplication*pattern for features returned from allFeature to make clear if a feature targets an entire application.Note, as a follow-up the query will be deprecated in the API and return an empty array.