feat: introduce new package @commercetools-backend/express with utilities for working with Custom Applications #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/commercetools/merchant-center-application-kit/5b4l43ysh |
emmenko
force-pushed
the
nm-server-express
branch
from
f130d24
to
e4c41b0
Compare
tdeekens
reviewed
Apr 18, 2020
emmenko
commented
Apr 20, 2020
tdeekens
reviewed
Apr 20, 2020
| @@ -0,0 +1,45 @@ | |||
| # @commercetools-backend/server-express | |||
There was a problem hiding this comment.
Sorry, do we do express or server-express? Intuitively I would just go with express 🤷 😕
There was a problem hiding this comment.
Yeah I guess with the "backend" prefix we can just use express
| } | ||
| const cloudIdentifierHeader = request.header('x-mc-api-cloud-identifier'); | ||
| const issuer = | ||
| options.inferIssuer && cloudIdentifierHeader |
| default: | ||
| return undefined; | ||
| } | ||
| }; | ||
| const throwIfIssuerIsNotAValidUrl = (issuer: string) => { |
|
So for further work on the package, I suppose we can merge this and open other PRs? |
emmenko
changed the title
tdeekens
approved these changes
Apr 20, 2020
emmenko
force-pushed
the
nm-server-express
branch
from
e5b910b
to
a2a62ee
Compare
tdeekens
reviewed
Apr 20, 2020
|
Just a mistake 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1444
cc @adnasa for awareness