fix(ECS): serialize error like objects

serialize error like objects not only error instances.
fix absent headers object in req ecs serializer.

src/ecs/LogEcs.js

@@ -75,8 +75,8 @@ function toJson (obj, serializers) {
       serializers[key](value, ecsObj)
     } else {
       // add all other unknown fields to extra
-      ecsObj.extra = ecsObj.extra || {}
-      ecsObj.extra[key] = normToString(value)
+      ecsObj.extra = ecsObj.extra || { [name]: {} }
+      ecsObj.extra[name][key] = normToString(value)
     }
   }
 

src/ecs/serializers.js

@@ -3,7 +3,7 @@ import { startTimeKey } from '../serializers/res.js'
 const isNotObject = (any) => !any || typeof any !== 'object'
 
 const ecsError = (err, ecsObj) => {
-  if (!(err instanceof Error)) {
+  if (!(err?.message)) {
     return
   }
 
@@ -63,7 +63,7 @@ const ecsReq = (req, ecsObj) => {
     authorization,
     'user-agent': userAgent,
     ...headers
-  } = req.headers
+  } = req.headers || {}
 
   ecsObj.http = ecsObj.http || {}
   ecsObj.http.request = {

test/LogEcs.test.js

@@ -37,6 +37,22 @@ describe('LogEcs', function () {
           }
         })
       })
+
+      it('shall serialize an error like object', function () {
+        const ecsFields = {}
+        const err = { name: 'TypeError', message: 'boom' }
+        err.code = 'oneFinger'
+        ecsError(err, ecsFields)
+        assert.equal(ecsFields.error.stack_trace, undefined)
+        ecsFields.error.stack_trace = '#'
+        assert.deepStrictEqual(ecsFields, {
+          error: {
+            type: 'Object',
+            message: 'boom',
+            stack_trace: '#'
+          }
+        })
+      })
     })
 
     describe('ecsReq', function () {
@@ -126,6 +142,39 @@ describe('LogEcs', function () {
           }
         })
       })
+
+      it('shall serialize a request without headers', function () {
+        const _req = {
+          ...req,
+          originalUrl: '/mount/test/path?test=1',
+          httpVersion: '2.0',
+          headers: null
+        }
+
+        const ecsFields = {}
+        ecsReq(_req, ecsFields)
+        assert.deepStrictEqual(ecsFields, {
+          client: {
+            ip: '127.0.0.1',
+            port: 3333
+          },
+          url: {
+            path: '/mount/test/path',
+            query: 'test=1'
+          },
+          http: {
+            request: {
+              id: 'f90a5d9e-52e6-482e-a6ab-d1c5da1fe9c6',
+              method: 'GET',
+              version: '2.0',
+              headers: {}
+            }
+          },
+          user_agent: {
+            original: undefined
+          }
+        })
+      })
     })
 
     describe('ecsRes', function () {
@@ -241,15 +290,15 @@ describe('LogEcs', function () {
       const res = log.error({ largeString })
       assert.strictEqual(
         res,
-        '{"log":{"level":"ERROR","logger":"test","diff_ms":0},"@timestamp":"1970-01-01T00:00:00.000Z","extra":{"largeString":"111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111"}}'
+        '{"log":{"level":"ERROR","logger":"test","diff_ms":0},"@timestamp":"1970-01-01T00:00:00.000Z","extra":{"test":{"largeString":"111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111"}}}'
       )
     })
 
     it('should remove infinite number and function', function () {
       const res = log.error({ number: Infinity, fn: () => {} })
       assert.strictEqual(
         res,
-        '{"log":{"level":"ERROR","logger":"test","diff_ms":0},"@timestamp":"1970-01-01T00:00:00.000Z","extra":{"number":"Infinity"}}'
+        '{"log":{"level":"ERROR","logger":"test","diff_ms":0},"@timestamp":"1970-01-01T00:00:00.000Z","extra":{"test":{"number":"Infinity"}}}'
       )
     })