Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests before publish, but not during install #26

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Run tests before publish, but not during install #26

merged 1 commit into from
Jan 23, 2023

Conversation

shadowspawn
Copy link
Contributor

Problem

Gosh darn it, prepublish is still running on install, so can't fix up the install and add Commander before running the tests on old versions of Node.js!

Solution

Switch to prepublishOnly. (Won't run tests before pack, but we don't use pack directly.)

abetomo
abetomo approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn merged commit 03cb838 into develop Jan 23, 2023
@shadowspawn shadowspawn deleted the feature/prepublishOnly branch January 23, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadowspawn @abetomo