Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is still work in progress but wanted to share to get some feedback.
As you know Ecto moved away to Jason in v3, which breaks Commanded.
This PR is an effort to align Commanded with Ecto by moving it to Jason as well.
I've made a couple assumptions in this PR which i'm happy to discuss:
@derive Jason.Encoder
vs the implicit behavior in Poison.. If you think this is too harsh of a change, i think we can, with more work, do something to have a better upgrade experience. E.g have a Commanded.JsonEncoder which will define the encoding behaviour depending if Jason or Poison is loaded and basically delegate to the appropriate@derive
. But this is quite a lot of work and i'm not sure its worth the effort - What do you think?I've updated the documentation but i think more needs to be written in regard to this change.
Help appreciated.
Thank you for the awesome lib!