-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GM: Cruise Fault on start up #30201
Comments
Is this recent or has it being doing this as long as you can remember? Can you try this:
My guess is the ECUs are temp faulted until the C3 fully boots up and starts sending messages for a second or so. Which is expected since we unplug the stock ASCM and the ECUs expect the messages immediately on startup, so there's not too much we can do. |
I think that this issue has been around for a long time. I've been on @twilsonco's fork for the custom lateral tuning, but with all of the new advances, it would be nice to use Stock OpenPilot without error. I also think that Twilsonco resolved this by adding a delay somewhere. I created this route based off of your instruction and still get the error. df51b2195de66a9b|2023-10-10--08-37-36--0 |
Sounds right that this can't really be helped other than by ignoring the fault after startup. I don't think |
Yep, it cleared 1 second after we started sending our messages. I'll keep this open to check if there's any initialization signals briefly. I recall one on our Bolt but didn't save it |
This fault is expected for this hardware setup, we can look into generically detecting and hiding these alerts without false positives in the future if more cars are like this. Closing for now. |
I want to chime in here because I'm running into openpilot/selfdrive/car/gm/values.py Line 209 in 72cc2e3
PYTHONPATH=/data/openpilot PREPAREONLY=1 /data/openpilot/selfdrive/debug/get_fingerprint.py
I tried cc @nworb-cire |
Here's another longer session |
This isn't related to this issue. Both the ECM and the brake control module reports a fault, plus your camera is sending Does your car have the ACC package? Can you send a photo of your steering wheel? openpilot requires: |
As I mentioned, I went ahead and installed the comma in a brand new Chevy Bolt EV 2023 2LT and after mounting it and booting it for the first time I got the openpilot/selfdrive/car/gm/values.py Line 209 in 72cc2e3
PYTHONPATH=/data/openpilot PREPAREONLY=1 /data/openpilot/selfdrive/debug/get_fingerprint.py
That's probably because I had the
Yeah, it should. It's a Chevy Bolt EV 2023 2LT, a brand new one though.
Sure thing! There you go 👀
Yeah I know, I was also surprised that it didn't work out of the box when I installed it. Thanks a lot for you help troubleshooting my issue. Please, let me know if I should create a separate ticket to keep track of the progress. |
Does your car already brake for lead cars when using cruise control? |
Will test, as mentioned we got the car a couple of days ago and couldn't test-drive all the features yet. In any case, what are you thinking? Do you think it's an issue with the car system? |
According to the options codes for this 2023 Chevy Bolt EV LT2, it does not have ACC. The vehicle needs to be an LT2 trim level, but it also needs the optional Infotainment package (JSA) $695 and the Adaptive Cruise Control option (KSG) $495 For the record: He returned this vehicle to the selling dealer and they allowed him to replace it with a vehicle that did have ACC. |
Describe the bug
Every time the vehicle is started, the Comma device shows a "Cruise Fault: Restart the car to engage" error that resolves on its own within a few seconds.
Provide a route where the issue occurs
df51b2195de66a9b|2023-10-06--13-36-10--0
openpilot version
Comma Nightly @ f40b1da
Additional info
No response
The text was updated successfully, but these errors were encountered: