Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GM: Cruise Fault on start up #30201

Closed
Verylukyguy opened this issue Oct 6, 2023 · 12 comments
Closed

GM: Cruise Fault on start up #30201

Verylukyguy opened this issue Oct 6, 2023 · 12 comments
Labels
bug car vehicle-specific gm

Comments

@Verylukyguy
Copy link
Contributor

Verylukyguy commented Oct 6, 2023

Describe the bug

Every time the vehicle is started, the Comma device shows a "Cruise Fault: Restart the car to engage" error that resolves on its own within a few seconds.

Provide a route where the issue occurs

df51b2195de66a9b|2023-10-06--13-36-10--0

openpilot version

Comma Nightly @ f40b1da

Additional info

No response

@Verylukyguy Verylukyguy added the bug label Oct 6, 2023
@sshane
Copy link
Contributor

sshane commented Oct 10, 2023

Is this recent or has it being doing this as long as you can remember?

Can you try this:

  • Turn car on with C3 unplugged, leave in park (might show dash faults)
  • Then plug in C3 and wait for it to boot, post route

My guess is the ECUs are temp faulted until the C3 fully boots up and starts sending messages for a second or so. Which is expected since we unplug the stock ASCM and the ECUs expect the messages immediately on startup, so there's not too much we can do.

@sshane sshane added car vehicle-specific gm labels Oct 10, 2023
@Verylukyguy
Copy link
Contributor Author

Verylukyguy commented Oct 10, 2023

I think that this issue has been around for a long time.

I've been on @twilsonco's fork for the custom lateral tuning, but with all of the new advances, it would be nice to use Stock OpenPilot without error.

I also think that Twilsonco resolved this by adding a delay somewhere.

I created this route based off of your instruction and still get the error.

df51b2195de66a9b|2023-10-10--08-37-36--0

@twilsonco
Copy link
Contributor

Sounds right that this can't really be helped other than by ignoring the fault after startup. I don't think Andrew C#1350's method produces this issue, since he bypasses the ASCM with a panda in a way that forwards all the signals.

@sshane
Copy link
Contributor

sshane commented Oct 10, 2023

Yep, it cleared 1 second after we started sending our messages. I'll keep this open to check if there's any initialization signals briefly. I recall one on our Bolt but didn't save it

@sshane
Copy link
Contributor

sshane commented Oct 21, 2023

This fault is expected for this hardware setup, we can look into generically detecting and hiding these alerts without false positives in the future if more cars are like this. Closing for now.

@sshane sshane closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2023
@Guardiola31337
Copy link

Guardiola31337 commented Nov 10, 2023

I want to chime in here because I'm running into Cruise Fault: Restart the car to engage error but in my case it doesn't resolve and the message doesn't go away (waited a long time and even drove and it kept showing). This is on a brand new Chevy Bolt EV 2023 2LT. Worth mentioning that initially I run into Dashcam Mode Car Unrecognized which I was able to remove after adding the fingerprints as described in https://github.com/commaai/openpilot/wiki/Fingerprinting#fingerprinting-10 i.e. replaced

189: 7, 190: 7, 193: 8, 197: 8, 201: 8, 209: 7, 211: 3, 241: 6, 257: 8, 288: 5, 289: 8, 298: 8, 304: 3, 309: 8, 311: 8, 313: 8, 320: 4, 322: 7, 328: 1, 352: 5, 381: 8, 384: 4, 386: 8, 388: 8, 451: 8, 452: 8, 453: 6, 458: 5, 463: 3, 479: 3, 481: 7, 485: 8, 489: 8, 497: 8, 500: 6, 501: 8, 528: 5, 532: 6, 560: 8, 562: 8, 563: 5, 565: 5, 566: 8, 587: 8, 608: 8, 609: 6, 610: 6, 611: 6, 612: 8, 613: 8, 707: 8, 715: 8, 717: 5, 753: 5, 761: 7, 789: 5, 800: 6, 810: 8, 840: 5, 842: 5, 844: 8, 848: 4, 869: 4, 880: 6, 977: 8, 1001: 8, 1017: 8, 1020: 8, 1217: 8, 1221: 5, 1233: 8, 1249: 8, 1265: 8, 1280: 4, 1296: 4, 1300: 8, 1611: 8, 1930: 7
by the fingerprint that I got from PYTHONPATH=/data/openpilot PREPAREONLY=1 /data/openpilot/selfdrive/debug/get_fingerprint.py

599ef8fe5b42e9fc|2023-11-09--23-43-30

I tried release3 and master-ci and still the alert doesn't disappear. Any ideas @sshane @twilsonco?

cc @nworb-cire

@Guardiola31337
Copy link

Here's another longer session 599ef8fe5b42e9fc|2023-11-09--23-32-44--2.

cc @sshane @twilsonco @nworb-cire

@sshane
Copy link
Contributor

sshane commented Nov 10, 2023

This isn't related to this issue. Both the ECM and the brake control module reports a fault, plus your camera is sending ACCAlwaysOne=0 which usually means it does not have ACC ("Forward Collision Alert Present").

Does your car have the ACC package? Can you send a photo of your steering wheel? openpilot requires: 2LT Trim with Adaptive Cruise Control Package

@Guardiola31337
Copy link

@sshane

This isn't related to this issue. Both the ECM and the brake control module reports a fault

As I mentioned, I went ahead and installed the comma in a brand new Chevy Bolt EV 2023 2LT and after mounting it and booting it for the first time I got the Dashcam Mode Car Unrecognized alert. Dug how to fix it and I was able to remove it after adding the fingerprints as described in https://github.com/commaai/openpilot/wiki/Fingerprinting#fingerprinting-10 i.e. replaced

189: 7, 190: 7, 193: 8, 197: 8, 201: 8, 209: 7, 211: 3, 241: 6, 257: 8, 288: 5, 289: 8, 298: 8, 304: 3, 309: 8, 311: 8, 313: 8, 320: 4, 322: 7, 328: 1, 352: 5, 381: 8, 384: 4, 386: 8, 388: 8, 451: 8, 452: 8, 453: 6, 458: 5, 463: 3, 479: 3, 481: 7, 485: 8, 489: 8, 497: 8, 500: 6, 501: 8, 528: 5, 532: 6, 560: 8, 562: 8, 563: 5, 565: 5, 566: 8, 587: 8, 608: 8, 609: 6, 610: 6, 611: 6, 612: 8, 613: 8, 707: 8, 715: 8, 717: 5, 753: 5, 761: 7, 789: 5, 800: 6, 810: 8, 840: 5, 842: 5, 844: 8, 848: 4, 869: 4, 880: 6, 977: 8, 1001: 8, 1017: 8, 1020: 8, 1217: 8, 1221: 5, 1233: 8, 1249: 8, 1265: 8, 1280: 4, 1296: 4, 1300: 8, 1611: 8, 1930: 7
by the fingerprint that I got from PYTHONPATH=/data/openpilot PREPAREONLY=1 /data/openpilot/selfdrive/debug/get_fingerprint.py

plus your camera is sending ACCAlwaysOne=0 which usually means it does not have ACC ("Forward Collision Alert Present").

That's probably because I had the Record and Upload Driver camera toggle disabled.

Does your car have the ACC package?

Yeah, it should. It's a Chevy Bolt EV 2023 2LT, a brand new one though.

Can you send a photo of your steering wheel?

Sure thing! There you go 👀

PXL_20231110_122603260

PXL_20231110_122727216

openpilot requires: 2LT Trim with Adaptive Cruise Control Package

Yeah I know, I was also surprised that it didn't work out of the box when I installed it.

Thanks a lot for you help troubleshooting my issue. Please, let me know if I should create a separate ticket to keep track of the progress.

@sshane
Copy link
Contributor

sshane commented Nov 10, 2023

Does your car already brake for lead cars when using cruise control?

@Guardiola31337
Copy link

Does your car already brake for lead cars when using cruise control?

Will test, as mentioned we got the car a couple of days ago and couldn't test-drive all the features yet. In any case, what are you thinking? Do you think it's an issue with the car system?

@Verylukyguy
Copy link
Contributor Author

Verylukyguy commented Nov 10, 2023

According to the options codes for this 2023 Chevy Bolt EV LT2, it does not have ACC.

The vehicle needs to be an LT2 trim level, but it also needs the optional Infotainment package (JSA) $695 and the Adaptive Cruise Control option (KSG) $495

For the record: He returned this vehicle to the selling dealer and they allowed him to replace it with a vehicle that did have ACC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug car vehicle-specific gm
Projects
None yet
Development

No branches or pull requests

4 participants