Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$100 bounty] GM: get VIN #26927

Closed
sshane opened this issue Jan 12, 2023 · 6 comments
Closed

[$100 bounty] GM: get VIN #26927

sshane opened this issue Jan 12, 2023 · 6 comments
Labels
bounty car vehicle-specific enhancement gm good first issue Feasible for new contributers

Comments

@sshane
Copy link
Contributor

sshane commented Jan 12, 2023

You simply need to allow a different subset of addresses to send to in ELM mode (think 0x200 range?)

@sshane sshane added enhancement good first issue Feasible for new contributers car vehicle-specific gm labels Jan 12, 2023
@varshneydevansh
Copy link

varshneydevansh commented Aug 7, 2023

Hi @sshane ,

Can I pick this challenge and if possible, can you point me the initial file where to begin as I am new to this project?

@leoforney
Copy link

I think this might have to do with getting VIN on GM:
https://docs.google.com/spreadsheets/d/1qEwOXSr3bWoc2VUhpuIam236OOZxPc2hxpLUsV0xkn0/edit#gid=2
Row 162 and 163

@varshneydevansh
Copy link

@leoforney Thank you so much. I will start working on this in December. Currently working on my writing thing. =)

@adeebshihadeh adeebshihadeh changed the title GM: get VIN [$100 bounty] GM: get VIN Jan 20, 2024
@garrettpall
Copy link
Contributor

garrettpall commented Jan 22, 2024

@sshane What's wrong with using VIN_part1 and VIN_part2 signals?

@sshane
Copy link
Contributor Author

sshane commented Jan 23, 2024

Right now openpilot generates carParams once on startup, this requires a bit of a change to the architecture of openpilot. Doable, and we might want to do this since other cars also publish their VIN like this, but with the Bolt at least, we can just query the camera as the easiest way to get the VIN, right now.

@sshane
Copy link
Contributor Author

sshane commented Jan 30, 2024

Done in #31224

@sshane sshane closed this as completed Jan 30, 2024
@github-project-automation github-project-automation bot moved this from Open to Done in openpilot bounties Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty car vehicle-specific enhancement gm good first issue Feasible for new contributers
Projects
Status: Done
Development

No branches or pull requests

5 participants