Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enter pre-enabled state when engaging at standstill with brake pressed #25425

Open
adeebshihadeh opened this issue Aug 13, 2022 · 2 comments
Open

Enter pre-enabled state when engaging at standstill with brake pressed #25425

adeebshihadeh opened this issue Aug 13, 2022 · 2 comments
Assignees
@sshane
Labels
enhancement

Comments

@adeebshihadeh
Copy link
Contributor

In this case, we'll need to allow brake actuation to prevent creeping and maintain standstill. However, steering and gas should be blocked. Requires enforcement in both openpilot and panda safety.
@sshane sshane self-assigned this Aug 13, 2022
@adeebshihadeh
Copy link
Contributor Author

@sshane this still relevant?

@sshane
Copy link
Contributor

sshane commented Nov 8, 2024

Yes, the safety isn't merged: commaai/panda#1123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sshane sshane

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adeebshihadeh @sshane