-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2017 Subaru Impreza ping pong in lane #20397
Comments
Please fill out the bug report template with dongle id and drive(s). |
Hi Willemstad,
Where would I find the report template? And what’s the dongle Id?
Maurice
Best Regards
On Mar 18, 2021, at 11:45 AM, Willem Melching ***@***.***> wrote:
Please fill out the bug report template with dongle id and drive(s).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
When you create a new issue on github it will populate with a template. Basically we want this info: Device: [e.g. EON/EON Gold/comma two] |
Device/Version information (please complete the following information): Device: Comma2 |
Steer Actuator Delay is too high- should be lowered by .2 to reflect the new MPC |
Thanks. However, how do I go about making this fix?
Maurice
Best Regards
On Mar 27, 2021, at 10:55 AM, RCoaster ***@***.***> wrote:
Steer Actuator Delay is too high- should be lowered by .2 to reflect the new MPC
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
You will need to ssh and cd into /data/openpilot/selfdrive/car/subaru and use 'nano interface.py' to modify the value from 0.4 to 0.2. I'm in the same boat as you with pingponging, i've made this change and I'm going to test it out |
i've made the change, and it is significantly better, but there's still some room for improvement. in the video below specifically watch around the 1:15 mark, you can see it still gets pretty close to the lane line, and there is still pingponging BUT it will maintain the lane in this short drive. https://www.youtube.com/watch?v=n4QwyiiONUo do you have any suggestions on the next value to adjust? |
Can confirm (as I have an 18 Impreza, which is the exact same car), this is not an OP bug. It's related to tuning. Likely worth closing this as 0.8.3 corrected a lot of the lateral issues seen in 0.8.2. Rest can be tuned out. |
OK. I'm still on 0.8.2 and the device is not giving me the option to do the OTA update to 0.8.3. I tried powering down and resting the device but it's still on 0.8.2. |
@Jahmangy if you're not on stock, you'll need to ask your fork maintainer. Likely either "fk da police" or "mlp" in the Subaru channel on Discord. |
It's on stock. Everything is stock. I'm just trying to get it to work after my first experience with my initial drive. |
Fair enough! Well, I'd connect to Wifi if you haven't already, and just let it sit for 5 minutes. It should prompt you. If all else fails, just head to Settings -> Device (might be under Developer) -> Uninstall openpilot, then follow the instructions to install openpilot again. |
Closing this since it sounds like a tuning issue and lateral performance on subarus should be improved with recent versions. |
My 2017 Subaru Impreza does not drive straight between the lane lines to a point that it’s not useable. Help!!
The text was updated successfully, but these errors were encountered: