fix: fix to stop Accordion interaction submitting an wrapping form (#679

)
comicrelief · Oct 31, 2024 · 3655ca1 · 3655ca1
1 parent dd43bf3
commit 3655ca1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/components/Molecules/Accordion/Accordion.js b/src/components/Molecules/Accordion/Accordion.js
@@ -83,7 +83,7 @@ const Accordion = ({
 
   return (
     <Container {...rest}>
-      <Button onClick={handleOpen} aria-expanded={isOpen ? 'true' : 'false'} ChevronKeyframes={ChevronKeyframes}>
+      <Button onClick={handleOpen} aria-expanded={isOpen ? 'true' : 'false'} ChevronKeyframes={ChevronKeyframes} type="button">
         {title}
         <Icon>
           <Chevron colour="black" direction={isOpen ? 'up' : 'down'} />

diff --git a/src/components/Molecules/Accordion/__snapshots__/Accordion.test.js.snap b/src/components/Molecules/Accordion/__snapshots__/Accordion.test.js.snap
@@ -114,6 +114,7 @@ exports[`renders correctly 1`] = `
     aria-expanded="false"
     className="c1"
     onClick={[Function]}
+    type="button"
   >
     <h2
       className="c2"