Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Load Image Output node #6790

Merged

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Feb 12, 2025

Adds Load Image node with remote widget. When refreshed, it re-fetches the values from the given route (in this case, files from output folder). This node can test the features detailed in Comfy-Org/rfcs#1 (lazy loading widget with remote source, changes to COMBO input spec).

refresh-button-lazy-widget.mp4

Frontend:

Test nodes, Unit tests, E2E tests

@huchenlei huchenlei added Important Feature A new feature to add to ComfyUI. labels Feb 17, 2025
@comfyanonymous comfyanonymous merged commit afc85cd into comfyanonymous:master Feb 18, 2025
9 checks passed
@christian-byrne christian-byrne deleted the load-image-output-node branch February 19, 2025 03:27
@doctorpangloss
Copy link

this is breaking a lot of custom nodes and probably needs to be reverted and implemented differently

@christian-byrne
Copy link
Contributor Author

this is breaking a lot of custom nodes and probably needs to be reverted and implemented differently

Which custom nodes?

@ManOrMonster
Copy link

ManOrMonster commented Feb 20, 2025

Affects at least Video Helper Suite and Fill Nodes with their latest updates on ComfyUI Desktop. This is the offender, which you already pointed out on the VHS thread: https://github.com/Comfy-Org/ComfyUI_frontend/blob/0d6bc669f56f8aefcad11e39f3642a852efabf14/src/composables/widgets/useComboWidget.ts#L18

ComfyUI Desktop will fix this on the next release. In the meantime, reverting to a slightly older version of VHS and Fill Nodes in the Manager resolves the issue.

@christian-byrne
Copy link
Contributor Author

The changes from this PR in particular don't cause the bug. The bug happens because ComfyUI Desktop has a slight delay in updating frontend version. The bug is entirely on the frontend and its interaction with a few extensions.

@ManOrMonster
Copy link

Right. Except a "slight delay" in AI terms is practically weeks. This has made me seriously question using ComfyUI Desktop going forward. When a breaking bug like this comes up, "we'll fix it in the next release" is unaccapetable when no timeline is given and no interim solution is offered. Once this was discovered, an immediate release should have been offered for resolution. Instead, I had to discover how to resolve it myself, and still the next release is not available.

@webfiltered
Copy link
Collaborator

This has made me seriously question using ComfyUI Desktop going forward.

Fair enough. If you do decide to stop using the desktop app, maybe once we are out of the public beta phase you can give it another shot.

This isn't the experience we want for our users, though; the team spoke earlier about how this came about, and how we can prevent it from happening again.

still the next release is not available

Or is? https://github.com/Comfy-Org/desktop/releases/tag/v0.4.20

@ManOrMonster
Copy link

It wasn't yet out when I wrote that, but the release was still fairly quick, so kudos to the team for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature to add to ComfyUI. Important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants