Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document get_attr and get_model_object #6357

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Document get_attr and get_model_object #6357

merged 4 commits into from
Jan 7, 2025

Conversation

huchenlei
Copy link
Collaborator

Resolves #6303

This PR adds documentation on comfy.utils.get_attr pointing developer to ModelPatcher.get_model_object.

blepping
blepping reviewed Jan 6, 2025
View reviewed changes
comfy/model_patcher.py Outdated Show resolved Hide resolved
@huchenlei huchenlei added the documentation Improvements or additions to documentation label Jan 7, 2025
@comfyanonymous comfyanonymous merged commit d055325 into master Jan 7, 2025
8 checks passed
@comfyanonymous comfyanonymous deleted the document_get_attr branch January 7, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blepping blepping blepping left review comments

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous comfyanonymous is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ModelPatcher] object patch not properly removed between runs
3 participants
@huchenlei @blepping @comfyanonymous