resolve relative paths in YAML configuration for extra model paths #5847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bigcat88 <bigcat88@icloud.com>
|
this is a great idea -- I just put up #5864 for expanding out the yaml paths config, but I didn't really resolve what "." is in that yaml. This makes it clear. I'll make sure that PR behaves this same way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
load_extra_path_configfunction to properly handle relative paths in YAML configuration files.Relative paths are now resolved relative to the directory containing the YAML file.
Changes:
os.path.isabsto determine whether a path is relative or absolute.base_pathis not specified.This PR introduces minimal changes and only affects cases where
base_pathis not set.As far as I know, there are no breaking changes.