URL-decode path from API #4754
Closed
URL-decode path from API #4754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -139,6 +140,9 @@ def get_user_data_path(request, check_exists = False, param = "file"): | |||
| if not file: | |||
| return web.Response(status=400) | |||
|
|
|||
| # Decode URL-encoded file path | |||
| file = urllib.parse.unquote(file); | |||
There was a problem hiding this comment.
You don't need that semicolon in python. :)
I would remove that.
Suggested change
| file = urllib.parse.unquote(file); | |
| file = urllib.parse.unquote(file) |
There was a problem hiding this comment.
@TobTobXX not sure why you marked this as resolved but didn't actually resolve it? There's still a semicolon there
|
Hey any updates on this? It's currently breaking my ComfyUI setup and makes it hard to update without it. If needed I can make the changes and submit another PR if it'll push this along faster. |
Tip: When running into breaking bugs like this, just download the fixing commit as a patch and apply it yourself. # Apply patches
COPY *.patch ./
RUN git apply *.patch && rm *.patch |
|
#4801 replaced this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4753.