Add handling for vace_context in context windows #11386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drozbay
requested review from
Kosinkadink,
comfyanonymous and
guill
as code owners
Contributor
Author
|
Example using 49 frame context with no reference: VACEContextWin_00002_.mp4Example WF: droz_VacePose_native_basic.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply slices up
vace_contextby window to allow the usage of VACE conditioning with Context Windows.Since the reference image is not separated from the rest of the VACE context, there is no way to know if it includes a reference image. When the
retain_index_listparameter set to 0 the reference frame will be applied properly to each context window. Consider exposing this option so that users can use VACE with context windows and reference frames.