fix: remove trailing underscore from output filenames #11379
+110
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes comfyanonymous#1389 Removed the unnecessary trailing underscore from output filenames. - Old format: ComfyUI_00001_.png - New format: ComfyUI_00001.png Updated get_save_image_path to support both formats for backward compatibility with existing files.
majiayu000
requested review from
Kosinkadink,
comfyanonymous and
guill
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
Closes #1389
Changes
ComfyUI_00001_.pngComfyUI_00001.pngBackward Compatibility
Updated
get_save_image_pathto recognize both old and new filenameformats, so existing files with trailing underscores will still work.
Test
Added
tests-unit/folder_paths_test/test_filename_format.py