fix: close image file handle after loading in LoadImage nodes #11378
+139
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes comfyanonymous#3477 The LoadImage and LoadImageMask nodes opened image files but did not close them after processing. This kept file handles open, preventing other processes from accessing the files. Added try/finally blocks to ensure img.close() is called after processing completes.
majiayu000
requested review from
Kosinkadink,
comfyanonymous and
guill
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
Closes #3477
Problem
Image files were opened but not closed, keeping file handles open and
preventing other processes from accessing the files.
Solution
Added try/finally blocks to ensure
img.close()is called after processing.Test
Added
tests-unit/test_load_image_file_handle.py