[API Nodes] add Kling O1 model support #11025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kosinkadink
approved these changes
Dec 2, 2025
Collaborator
Kosinkadink
left a comment
Kosinkadink
left a comment
There was a problem hiding this comment.
loosk good, merging
mcmonkey4eva
reviewed
Dec 2, 2025
| with av.open(path, mode='w', options={'movflags': 'use_metadata_tags'}) as output: | ||
| extra_kwargs = {} | ||
| if format != VideoContainer.AUTO: | ||
| extra_kwargs["format"] = format.value |
Contributor
There was a problem hiding this comment.
This is a breaking change, this doesn't work. The input is traditionally a string, not an enum value, eg from the SaveVideo node it emits "mp4" not VideoContainer.MP4.
This means the SaveVideo node does not work since this update.
Contributor
There was a problem hiding this comment.
cc @Kosinkadink @comfyanonymous fatal breaking bug for a lot of video workflows^
Contributor
Author
There was a problem hiding this comment.
this should fix custom nodes
Contributor
There was a problem hiding this comment.
to be clear for the record, the error replication does not require custom nodes at all, though I see you did notice and patch the native SaveVideo node in the PR, so that looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR with price badges: Comfy-Org/ComfyUI_frontend#7077
API Node PR Checklist
Scope
Pricing & Billing
If Need pricing update:
QA
Comms