cms:file should not return true for is_cms_block? #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GBH
added a commit
that referenced
this pull request
Oct 12, 2012
cms:file should not return true for is_cms_block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cms:file tags were returning true for is_cms_block?, despite not using a block. I'm assuming this is an mistake, since PageFile and PageFiles are the file tags which use a block.
This was causing oddness with the new namespace support in pages: {{cms:file:test.png}} was interpreted as being from the 'test' namespace. Errors were missed due to the rescue nil when calling the form builder in /pages/_form_blocks.html.erb.