Validate length of Cms::Page slug and full_path #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently databases are just chopping off the tail end of any slug or full_path that is longer than the field lengths. With this change a helpful error message will be displayed to the user. We also added a view only field of full_path in the admin edit page, to show this error message. We also added some handy styles for disabled inputs.
GBH
added a commit
that referenced
this pull request
Aug 7, 2012
Validate length of Cms::Page slug and full_path
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently databases are just chopping off the tail end of any slug or full_path that is longer than the field lengths. With this change a helpful error message will be displayed to the user.
We also added a view only field of full_path in the admin edit page, to show this error message.
We also added some handy styles for disabled inputs.