Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: invalid
txs_results
returned for legacy ABCI responses #3031fix: invalid
txs_results
returned for legacy ABCI responses #3031Changes from 56 commits
e83d3b2
0740151
85353d1
617a788
d769a1f
2d22c60
49d708e
e4c4133
1796bac
29a63b4
b4fb5c7
057a842
e2762de
b664792
dfb2a50
1d3ba09
0d991d7
5ac46a9
22830bf
62b6d99
4cb5a80
c20435d
64b6702
a4eab7b
a7715cc
fad89e7
57d70fc
7641dbf
1a6f328
df88eda
8cab048
b6a8932
0f32ced
5e28c0e
c7f100a
d54f2a0
0e4d8c1
74f8351
5051932
ff34cca
09a0d28
009f425
49b3984
6e47324
c7e2fc0
9701da4
2071d2c
c87ebc3
728dbf6
4ce283e
6768a58
653c375
ee78b7c
ebbe640
07a2600
6b53cf1
0a8dc20
519475a
d78f8f7
6c9333a
2f3678c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if we don't break any API (not sure) it'd be good to include the error inside this error, so the caller can print it if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added unwrapped error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also logging as
Error()
notDebug()