Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade gogoproto to 1.4.11 #1609

Merged
merged 1 commit into from
Nov 14, 2023
Merged

deps: upgrade gogoproto to 1.4.11 #1609

merged 1 commit into from
Nov 14, 2023

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Nov 14, 2023

Companion to #1603

Fixes the following compilation error:

../../../go/pkg/mod/github.com/cosmos/gogoproto@v1.4.6/proto/merge.go:123:28:
type func(x *descriptorpb.FileDescriptorProto, y
*descriptorpb.FileDescriptorProto) bool of func(x, y
*descriptorpb.FileDescriptorProto) bool {…} does not match inferred type
func(a *descriptorpb.FileDescriptorProto, b
*descriptorpb.FileDescriptorProto) int for func(a E, b E) int

go: go1.21.3 darwin/amd64
cometbft: v0.38.0


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

Fixes the following compilation error:

```
../../../go/pkg/mod/github.com/cosmos/gogoproto@v1.4.6/proto/merge.go:123:28:
type func(x *descriptorpb.FileDescriptorProto, y
*descriptorpb.FileDescriptorProto) bool of func(x, y
*descriptorpb.FileDescriptorProto) bool {…} does not match inferred type
func(a *descriptorpb.FileDescriptorProto, b
*descriptorpb.FileDescriptorProto) int for func(a E, b E) int
```

go: go1.21.3 darwin/amd64
cometbft: v0.38.0
@melekes melekes added the dependencies Dependency updates label Nov 14, 2023
@melekes melekes self-assigned this Nov 14, 2023
@melekes melekes requested a review from a team as a code owner November 14, 2023 05:36
@melekes melekes mentioned this pull request Nov 14, 2023
3 tasks
@melekes melekes merged commit 1d48d73 into v0.38.x Nov 14, 2023
18 checks passed
@melekes melekes deleted the anton/gogoproto branch November 14, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants