-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pebbledb): remove isForceSync flag #125
Conversation
Downstream dependencies should use `SetSync`/`DeleteSync` to force flushing OS buffers to disk.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 76.91% 76.74% -0.17%
==========================================
Files 23 23
Lines 2058 2043 -15
==========================================
- Hits 1583 1568 -15
Misses 403 403
Partials 72 72
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general mixing concerns within one PR might be less desired but these are all minor changes so OK to merge it as is.
few extensions such as range deletion tombstones, table-level bloom filters, | ||
and updates to the MANIFEST format. | ||
|
||
XXX: there are reports of broken upgrade process when using [Cosmos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XXX: there are reports of broken upgrade process when using [Cosmos | |
CAVEAT: there are reports of broken upgrade process when using [Cosmos |
XXX is a jargon more appropriate for the code docs, I think.
Downstream dependencies should use
SetSync
/DeleteSync
to forceflushing OS buffers to disk.