chore(pebbledb): remove isForceSync flag #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downstream dependencies should use `SetSync`/`DeleteSync` to force flushing OS buffers to disk.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 76.91% 76.74% -0.17%
==========================================
Files 23 23
Lines 2058 2043 -15
==========================================
- Hits 1583 1568 -15
Misses 403 403
Partials 72 72
|
jmalicevic
approved these changes
Jan 25, 2024
jmalicevic
reviewed
Jan 25, 2024
mzabaluev
reviewed
Jan 25, 2024
| few extensions such as range deletion tombstones, table-level bloom filters, | ||
| and updates to the MANIFEST format. | ||
|
|
||
| XXX: there are reports of broken upgrade process when using [Cosmos |
There was a problem hiding this comment.
Suggested change
| XXX: there are reports of broken upgrade process when using [Cosmos | |
| CAVEAT: there are reports of broken upgrade process when using [Cosmos |
XXX is a jargon more appropriate for the code docs, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream dependencies should use
SetSync/DeleteSyncto forceflushing OS buffers to disk.