Skip to content

try universal image with no version#551

Merged
hmdunce merged 4 commits intomainfrom
universal-noversion
Jun 26, 2025
Merged

try universal image with no version#551
hmdunce merged 4 commits intomainfrom
universal-noversion

Conversation

@hmdunce
Copy link
Contributor

@hmdunce hmdunce commented Jun 26, 2025

Problem

codespace bad

Context

make codespace good again

@hmdunce hmdunce requested a review from a team as a code owner June 26, 2025 20:46
@hmdunce hmdunce marked this pull request as draft June 26, 2025 20:47
@hmdunce hmdunce marked this pull request as ready for review June 26, 2025 21:02
Copy link
Member

@seanmakesgames seanmakesgames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working snappy for me! Try out the latest version

@hmdunce
Copy link
Contributor Author

hmdunce commented Jun 26, 2025

ok yeah now I have no clue whether we should use onCreate on postCreate, but looks good to me 😄

one doc I read said postCreate is async in the background after container starts, but this doesn't seem true

github docs say to use postCreate

@seanmakesgames
Copy link
Member

ok yeah now I have no clue whether we should use onCreate on postCreate, but looks good to me 😄

one doc I read said postCreate is async in the background after container starts, but this doesn't seem true

github docs say to use postCreate

I noticed it pull up the terminal window and shows it running the command, so you can do other stuff while it's doing that. --which I think is what we want.

@hmdunce
Copy link
Contributor Author

hmdunce commented Jun 26, 2025

Hmm, I dunno:

@hmdunce ➜ /workspaces/hackmud_wiki (universal-noversion) $ pnpm start

> hackmud_wiki@0.0.1 start /workspaces/hackmud_wiki
> docusaurus start

sh: 1: docusaurus: not found
 ELIFECYCLE  Command failed.
 ```

@hmdunce
Copy link
Contributor Author

hmdunce commented Jun 26, 2025

Managed to do that twice before something popped up about postCreate.

Either way is better than what we have now 😄 so good to merge 😄

I wonder what updateContent is like 🤔

@seanmakesgames
Copy link
Member

Looks to be working on my end

Cursor_and_hackmud_wiki__Codespaces__—_Visual_Studio_Code

@hmdunce
Copy link
Contributor Author

hmdunce commented Jun 26, 2025

Right it's just that it gives you a terminal a while before postCreate even starts, and you might expect things to already work in that terminal.

But on the other hand it lets you start editing files right away.

So 🤷.

I will make a separate branch to test whether updateContent does the perfect thing -- let you edit files right away, but run pnpm install in the "foreground" in the main terminal that opens up, so you don't try to run pnpm start before it finishes.

@hmdunce hmdunce merged commit 357eb28 into main Jun 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants